Performance Test the invocation loop (fix #377) #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
changed the title
|
proceeding and merging without a review as this does not touch the library itself, just a mock server used for perf testing and the test script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-implement MAX_INVOCATIONS and fix shell script
Fix #377
Motivation:
In v1, there was a script measuring the performance of the invocation loop.
Re-instate this script to allow users and developers to measure the performance impact of their changes.
Modifications:
I re-implemented MAX_INVOCATIONS, to avoid the client looping against the Mock Server. But this time, MAX_INVOCATIONS is handled on the server, not on the client.
I slightly modified the script to work with v2 and the new MockServer.
Result:
The script works.
This PR has a dependency on #465